Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the problematic heading on roman error #641

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Show the problematic heading on roman error #641

merged 1 commit into from
Jan 21, 2024

Conversation

robinwhittleton
Copy link
Member

Previously it just gave a file reference, which doesn’t help much in poetry compilations for example. This bit me on the Mina Loy compilation.

Before:

Error  Heading tagged as roman numeral is invalid: poetry.xhtml.

After:

 Error  Heading tagged as roman numeral is invalid: XVIX in poetry.xhtml.

@robinwhittleton
Show the problematic heading on roman error
b1aaae6 
Previously it just gave a file reference, which doesn’t help much in poetry compilations for example.
@acabal acabal merged commit 7e28efe into master Jan 21, 2024
2 checks passed
@acabal
Copy link
Member

acabal commented Jan 21, 2024

Thanks!

@robinwhittleton robinwhittleton deleted the locate-roman-error branch January 21, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drgrigg drgrigg Awaiting requested review from drgrigg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinwhittleton @acabal